This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Conversation
ghost
assigned
alanshaw
force-pushed
the
chore/update-deps-20181207
branch
from
4c5b0f5 to
9424720
Compare
added 8 commits
December 14, 2018 09:55
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
These need to be unskipped when #856 gets merged. This frees us to merge other changes while we're waiting for fixes to happen there. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
force-pushed
the
chore/update-deps-20181207
branch
from
da9a90c to
100bf90
Compare
added 2 commits
December 14, 2018 11:16
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Member
Author
|
@vasco-santos I've added temporary skips for the DHT tests that went into This will allow us to push forward and merge the remaining PRs for 0.34 and wait for the DHT branch to be ready. Can you please ensure that they get re-enabled in the DHT branch before they are merged into master? |
Member
Author
|
@vasco-santos @daviddias CI is 🍀 - ok to merge? |
vasco-santos
approved these changes
Dec 15, 2018
Member
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
Go for it! I will rebase the DHT PR afterwards and re-enable them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.